[fftw3] add neon support by mschollerer · Pull Request #45222 · microsoft/vcpkg

mschollerer · 2025-04-25T08:08:13Z

add fftw3 patch for neon as seen in this source repository local PR FFTW/fftw3#275 that will probaby never be merged there.

Changes comply with the maintainer guide.
~~SHA512s are updated for each updated download.~~
~~The "supports" clause reflects platforms that may be fixed by this new version.~~
~~Any fixed CI baseline entries are removed from that file.~~
~~Any patches that are no longer applied are deleted from the port's directory.~~
The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
~~Only one version is added to each modified port's versions file.~~

…FTW/fftw3#275 that will never be merged

mschollerer · 2025-04-25T08:13:05Z

@microsoft-github-policy-service agree [company="{your company}"]

@microsoft-github-policy-service agree company="ifm electronic"

Billy O'Neal (BillyONeal) · 2025-04-25T19:13:45Z

#error:  "NEON only works in single precision on 32 bits ARM"

My understanding is that NEON is ARM32 only, not ARM64? I pushed a suggested edit, but given the title of this explicitly talking about ARM64 please look closely.

Billy O'Neal (BillyONeal) · 2025-04-25T19:21:36Z

On the arm_neon_android failure presumably you would want that one to work so I think you need to look at that.

mschollerer · 2025-04-28T14:31:39Z

ah so its not so easy as fftw will be compiled as fftw3 (double) fftw3f (float) and fftw3l (long double) module. Neon is available for arm32 in single precision (float) and for arm64 (double).

We just used it on arm64 where everything worked fine, so arm32 will need some adoptions where I need to dig deeper, not sure when I can achieve that.

mschollerer · 2025-04-28T14:50:36Z

the easiest thing would be to adapt the module options on arm32 to turn NEON off for fftw3 (not fftw3f!). So there would need to be a change here for arm32 to disable NEON for double:

vcpkg/ports/fftw3/portfile.cmake

Line 35 in 4e921c3

set(fftw3_options "")

what do you think Billy O'Neal (@BillyONeal)? its not very nice and I'm not sure if its possible, but it would make it work

Billy O'Neal (BillyONeal) · 2025-04-28T19:41:19Z

what do you think Billy O'Neal (@BillyONeal)? its not very nice and I'm not sure if its possible, but it would make it work

Unfortunately I don't really know anything about 'fftw3' to make this kind of call :(. I can help express what is intended to be supported in a way vcpkg understands, but if the build is actually broken it seems that needs to be fixed first.

Billy O'Neal (BillyONeal) · 2025-04-28T19:44:34Z

I cut off my commit that blocked to arm32 and kept only the ci.feature.baseline.txt changes. Sorry for it being more complex than expected :)

Billy O'Neal (BillyONeal) · 2025-04-28T23:58:39Z

/azp run

azure-pipelines · 2025-04-28T23:58:49Z

Azure Pipelines successfully started running 1 pipeline(s).

mschollerer · 2025-05-08T13:29:21Z

/azp run

azure-pipelines · 2025-05-08T13:29:28Z

Commenter does not have sufficient privileges for PR 45222 in repo microsoft/vcpkg

mschollerer · 2025-05-08T13:31:04Z

Looks like I cannot start the pipelines, Billy O'Neal (@BillyONeal) I did some reasonable changes that should fix hopefully all errors, can you please review my changes and trigger the pipelines again? Thanks a lot.

Kai Pastor (dg0yt)

CI doesn't run because you must resolve some conflicts.

Co-authored-by: Kai Pastor <dg0yt@darc.de>

mschollerer · 2025-05-08T19:34:58Z

CI doesn't run because you must resolve some conflicts.

ok, thanks for your support and suggestions. understood how things meant to be done. a small change was needed, but looks good from my side now

mschollerer · 2025-05-08T19:35:29Z

/azp run

azure-pipelines · 2025-05-08T19:35:35Z

Commenter does not have sufficient privileges for PR 45222 in repo microsoft/vcpkg

Kai Pastor (dg0yt)

You shouldn't change ci.features.baseline.txt. (Different sections.)

And there still is a merge conflict, preventing CI.

mschollerer · 2025-05-08T20:35:51Z

You shouldn't change ci.features.baseline.txt. (Different sections.)

And there still is a merge conflict, preventing CI.

ok, I'm not sure why Billy O'Neal (@BillyONeal) made a change to this?

Billy O'Neal (BillyONeal) · 2025-05-08T23:41:40Z

ok, I'm not sure why Billy O'Neal (@BillyONeal) made a change to this?

Because I was trying to make the test pass: https://dev.azure.com/vcpkg/public/_build/results?buildId=115098

fftw3[core,openmp]:x64-windows-static resulted in the unexpected state pass after 1.8 min

# Conflicts: # scripts/ci.feature.baseline.txt

Billy O'Neal (BillyONeal) · 2025-05-09T00:50:36Z

I see, the feature-fails were grouped together and I undid that. Reverted that part.

mschollerer · 2025-05-09T11:14:01Z

Looks good, thank you 🙂

Kai Pastor (dg0yt) · 2025-05-09T11:26:35Z

 symengine[tcmalloc](windows) = feature-fails # tcmalloc not found. See https://github.com/microsoft/vcpkg/issues/33576
 tgui[sdl2] = options # At least one of the backend features must be selected: sdl2 sfml
-vlfeat[openmp](osx) = feature-fails # No openmp on osx
+vlfeat[openmp](osx) = feature-fails # No openmp on osxa


Looking for a volunteer to remove the typo here.

volunteer found, done

michael-schollerer added 2 commits April 25, 2025 09:41

add fftw3 patch for neon as seen in this source repository local PR F…

521999f

…FTW/fftw3#275 that will never be merged

update vcpkg with changed fftw3 port

a5d1830

Lily Wang (LilyWangLL) assigned Mengna-Li Apr 25, 2025

Mengna-Li added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Apr 25, 2025

Billy O'Neal (BillyONeal) marked this pull request as draft April 25, 2025 19:21

mschollerer changed the title ~~[fftw3] add neon support for aarch64~~ [fftw3] add neon support arm Apr 28, 2025

mschollerer changed the title ~~[fftw3] add neon support arm~~ [fftw3] add neon support Apr 28, 2025

windows-static openmp actually works!

789b33a

Billy O'Neal (BillyONeal) force-pushed the mschollerer-add-fftw3-neon branch from 4e921c3 to 789b33a Compare April 28, 2025 19:43

add distinction for arm64 and arm32, clean up

c37d260

add android

4235d0f

Kai Pastor (dg0yt) reviewed May 8, 2025

View reviewed changes

Comment thread ports/fftw3/vcpkg.json Outdated

Comment thread versions/f-/fftw3.json Outdated

Comment thread ports/fftw3/portfile.cmake Outdated

Comment thread ports/fftw3/portfile.cmake Outdated

Comment thread ports/fftw3/portfile.cmake Outdated

mschollerer and others added 6 commits May 8, 2025 21:27

Update ports/fftw3/vcpkg.json as suggested in review

118d951

Co-authored-by: Kai Pastor <dg0yt@darc.de>

Update versions/f-/fftw3.json as suggested in review

d5776cb

Co-authored-by: Kai Pastor <dg0yt@darc.de>

Update ports/fftw3/portfile.cmake as suggested in review

a6b76ad

Co-authored-by: Kai Pastor <dg0yt@darc.de>

Update ports/fftw3/portfile.cmake as suggested in review

fdd003a

Co-authored-by: Kai Pastor <dg0yt@darc.de>

Update ports/fftw3/portfile.cmake as suggested in review

200d3e2

Co-authored-by: Kai Pastor <dg0yt@darc.de>

fftw3f can always be built with neon, fftw3l can never be

ea5eaf9

Kai Pastor (dg0yt) reviewed May 8, 2025

View reviewed changes

Billy O'Neal (BillyONeal) added 2 commits May 8, 2025 16:43

Merge remote-tracking branch 'origin/master' into HEAD

d4949e3

# Conflicts: # scripts/ci.feature.baseline.txt

Un-reorder in ci.feature.baseline.txt.

dd2535e

mschollerer marked this pull request as ready for review May 9, 2025 11:13

Kai Pastor (dg0yt) reviewed May 9, 2025

View reviewed changes

fix typo

b19a2e8

Mengna-Li added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label May 14, 2025

Mengna-Li approved these changes May 14, 2025

View reviewed changes

Javier Matos Denizac (JavierMatosD) merged commit 64810c6 into microsoft:master May 14, 2025

mschollerer mentioned this pull request May 27, 2025

CMake: added Neon support FFTW/fftw3#275

Open

mschollerer deleted the mschollerer-add-fftw3-neon branch May 27, 2025 12:18

Uh oh!

Conversation

mschollerer commented Apr 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mschollerer commented Apr 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Billy O'Neal (BillyONeal) commented Apr 25, 2025

Uh oh!

Billy O'Neal (BillyONeal) commented Apr 25, 2025

Uh oh!

mschollerer commented Apr 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mschollerer commented Apr 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Billy O'Neal (BillyONeal) commented Apr 28, 2025

Uh oh!

Billy O'Neal (BillyONeal) commented Apr 28, 2025

Uh oh!

Billy O'Neal (BillyONeal) commented Apr 28, 2025

Uh oh!

azure-pipelines Bot commented Apr 28, 2025

Uh oh!

mschollerer commented May 8, 2025

Uh oh!

azure-pipelines Bot commented May 8, 2025

Uh oh!

mschollerer commented May 8, 2025

Uh oh!

Kai Pastor (dg0yt) left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mschollerer commented May 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mschollerer commented May 8, 2025

Uh oh!

azure-pipelines Bot commented May 8, 2025

Uh oh!

Kai Pastor (dg0yt) left a comment

Choose a reason for hiding this comment

Uh oh!

mschollerer commented May 8, 2025

Uh oh!

Billy O'Neal (BillyONeal) commented May 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Billy O'Neal (BillyONeal) commented May 9, 2025

Uh oh!

mschollerer commented May 9, 2025

Uh oh!

Kai Pastor (dg0yt) May 9, 2025

Choose a reason for hiding this comment

Uh oh!

mschollerer May 9, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

mschollerer commented Apr 25, 2025 •

edited

Loading

mschollerer commented Apr 25, 2025 •

edited

Loading

mschollerer commented Apr 28, 2025 •

edited

Loading

mschollerer commented Apr 28, 2025 •

edited

Loading

mschollerer commented May 8, 2025 •

edited

Loading

Billy O'Neal (BillyONeal) commented May 8, 2025 •

edited

Loading