Skip to content

[dbus-cxx] add new port#47683

Merged
JavierMatosD merged 16 commits intomicrosoft:masterfrom
luadebug:dbus2
Oct 8, 2025
Merged

[dbus-cxx] add new port#47683
JavierMatosD merged 16 commits intomicrosoft:masterfrom
luadebug:dbus2

Conversation

@luadebug
Copy link
Copy Markdown
Contributor

@luadebug luadebug commented Oct 6, 2025

  • Changes comply with the maintainer guide.
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

aui-framework/aui#635
dbus-cxx/dbus-cxx#191

Resolves: #47617 (comment) avoid using "default-features".

@luadebug luadebug changed the title Dbus2 [dbus-cxx] add new port Oct 6, 2025
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we had to revert this PR before we had to maintain the version entry from the last merge. Do you mind bumping the port version to 1 and simply adding a new entry rather than overwriting this one?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me, but I do not know how this should look like.

Copy link
Copy Markdown
Contributor

@JavierMatosD JavierMatosD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment on version db

@luadebug luadebug requested a review from JavierMatosD October 6, 2025 21:08
@JavierMatosD JavierMatosD merged commit 35c82bb into microsoft:master Oct 8, 2025
18 checks passed
@luadebug luadebug deleted the dbus2 branch October 8, 2025 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants