Added Delayed Modular Reduction to inner sumcheck - #108
Merged
Conversation
srinathsetty
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: Direct follow up to apply Delayed Modular Reduction to the other sumcheck in Spartan #105. It was a direct performance boost that it could be applied to other sumcheck like computations very nicely
Optimizing the inner sumcheck in Spartan's with Delayed Modular reduction. It directly speeds up the inner sumcheck for Spartan, SpartanZk and NeutronNovaZk.
Spartan Benchmark: main vs benching/sha256-is-faster
SHA256 Single Hash (msg=1024B)
SHA256 Chain (msg=32B, chain=1028)
NeutronNova Results with DelayedModular Reduction:
NeutronNova ZK (instances=16, chain=64)
Summary
Consistent improvements across both benchmarks:
outer_sc: 23-36% fasterinner_sc: 11-12% faster