Open
Conversation
LukaszMendakiewicz
previously approved these changes
Sep 18, 2017
LukaszMendakiewicz
left a comment
LukaszMendakiewicz
left a comment
There was a problem hiding this comment.
Thanks. I guess this should now be squashed before merging.
benmcmorran
force-pushed
the
dev/bemcmorr/loc
branch
from
9fcceb2 to
6e8916d
Compare
|
Since this project switched to consuming NuGet through PackageReference for most of the packages (ideally should be for all, once we iron out some wrinkles around MicroBuild), does Flatten-NuGetPackages even make sense here, and don't the packages referenced through PackageReference pose any problems during analysis? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two globalization rules are currently violated.
CultureInfo.CurrentCultureis not always specified when formatting strings. This change appears to be low-priority, does not impact behavior, and may make the code noisier.