[WIP] feat: simple hex data colorization#381
Open
CreeperLin wants to merge 1 commit intomicrosoft:mainfrom
Open
[WIP] feat: simple hex data colorization#381CreeperLin wants to merge 1 commit intomicrosoft:mainfrom
CreeperLin wants to merge 1 commit intomicrosoft:mainfrom
Conversation
spatoa
suggested changes
Sep 11, 2023
spatoa
left a comment
spatoa
left a comment
There was a problem hiding this comment.
I would prefer a toggle option for something like this as I find it harder to read the data in some areas.
Contributor
|
The visual experience is terrible, you need to reduce the brightness and saturation of the colors so as not to interfere with the reading of the data. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Colorize hex data by treating each byte as an 8-bit color (3, 3, 2 bits for R, G and B). I find it useful visualizing binary data with unknown format.
Also an implementation on #279, although using RGB instead of HSL, and the alpha is currently fixed at 0.5.
If this feature is desirable, options to toggle it and change the alpha value and even palettes can be added in the future.