(custom data schema) Fix globalAttributes and valueSets being incorrectly nested inside tags#226
Merged
aeschli merged 3 commits intomicrosoft:mainfrom Feb 27, 2026
Merged
Conversation
Jamesernator
changed the title
Contributor
Author
|
@microsoft-github-policy-service agree |
aeschli
approved these changes
Feb 23, 2026
Collaborator
|
Thanks @Jamesernator ! |
aeschli
approved these changes
Feb 23, 2026
joaomoreno
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently in the schema the
globalAttributesandvalueSetskeys are nested inside thetagsproperties and consequently don't have any effect on the schema. This moves them to be at the same level astags(which also matches with the actual behavior of the language server).