Skip to content

Introduce Settings Icon into Env Manager View#1191

Merged
eleanorjboyd merged 10 commits intomicrosoft:mainfrom
eleanorjboyd:simple-roadrunner
Feb 6, 2026
Merged

Introduce Settings Icon into Env Manager View#1191
eleanorjboyd merged 10 commits intomicrosoft:mainfrom
eleanorjboyd:simple-roadrunner

Conversation

@eleanorjboyd
Copy link
Member

@eleanorjboyd eleanorjboyd commented Feb 6, 2026

fixes #1176

@eleanorjboyd eleanorjboyd self-assigned this Feb 6, 2026
@eleanorjboyd eleanorjboyd marked this pull request as draft February 6, 2026 00:11
@eleanorjboyd eleanorjboyd added the feature-request Request for new features or functionality label Feb 6, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces a settings icon to the Environment Manager view that opens workspace-level search settings, and changes the default workspace search path from an empty array to ["./**/.venv"] to enable automatic discovery of .venv folders in workspaces.

Changes:

  • Adds a gear icon button to the env-managers view that opens search path configuration
  • Sets default workspace search path to ./**/.venv for automatic venv discovery
  • Updates getWorkspaceSearchPaths() to use default values from package.json when no workspace-specific config exists
  • Simplifies test assertions and switches from hardcoded paths to more flexible path validation
  • Changes defaultEnvManager scope from "window" to "application" and removes extension version logging

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
package.json Adds searchSettings command, registers gear icon in env-managers view toolbar, changes workspaceSearchPaths default to ["./**/.venv"], and changes defaultEnvManager scope to "application"
package.nls.json Adds localized title for searchSettings command and updates descriptions for search path settings to mention glob-like discovery
src/features/views/envManagerSearch.ts New file implementing the openSearchSettings function that opens workspace settings filtered to python-envs search paths
src/extension.ts Registers the new searchSettings command handler and removes extension version logging
src/managers/common/nativePythonFinder.ts Updates getWorkspaceSearchPaths to return default values and changes logging from traceLog to traceVerbose with simplified output
src/test/managers/common/nativePythonFinder.getAllExtraSearchPaths.unit.test.ts Simplifies test assertions to be more resilient to cross-platform path differences and updates test data to use absolute paths where appropriate
Comments suppressed due to low confidence (1)

src/managers/common/nativePythonFinder.ts:750

  • The comment was updated from "prefer workspaceFolder > workspace" to "prefer workspaceFolder > workspace > default". While this accurately reflects the new code behavior, it's worth noting that this is a significant behavior change. Previously, when no workspace or workspace folder values were set, the function would return an empty array. Now it will return the default value from package.json.

This change means environments will now be discovered in ./**/.venv by default (once the glob pattern issue is fixed), which could significantly impact performance and behavior for users who haven't explicitly configured this setting. Consider whether this breaking change should be communicated to users through release notes or migration guidance.

        // For workspace settings, prefer workspaceFolder > workspace > default

@eleanorjboyd eleanorjboyd marked this pull request as ready for review February 6, 2026 04:33
@eleanorjboyd eleanorjboyd enabled auto-merge (squash) February 6, 2026 04:33
@vs-code-engineering vs-code-engineering bot added this to the February 2026 milestone Feb 6, 2026
@eleanorjboyd eleanorjboyd merged commit 3d4a402 into microsoft:main Feb 6, 2026
7 checks passed
@eleanorjboyd eleanorjboyd deleted the simple-roadrunner branch February 6, 2026 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature-request Request for new features or functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add search for environment UX feature

2 participants