Merge latest Library.Template#294
Merged
Merged
Conversation
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This makes it available in Copilot CLI. Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…emplate Specifically, this merges [38fa0d7 from that repo](AArnott/Library.Template@38fa0d7).
There was a problem hiding this comment.
Pull request overview
Updates this repo to align with the latest Library.Template, including dependency/tooling version bumps, PowerShell script hardening, and the migration of AI-assisted template merging guidance from a “prompt” artifact to a GitHub skill.
Changes:
- Update SDK/tooling/dependency versions (global.json, Microsoft Testing Platform, dotnet tools).
- Harden/standardize PowerShell scripts (use
-LiteralPath,Join-Path,ToLowerInvariant(), anddotnet msbuildfor-getItem). - Add template merge “skill” documentation and ignore C# Dev Kit cache artifacts.
Reviewed changes
Copilot reviewed 8 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tools/Get-NuGetTool.ps1 | Uses -LiteralPath when validating nuget.exe path existence for safer path handling. |
| tools/Get-ExternalSymbolFiles.ps1 | Removes SupportsShouldProcess and switches package version evaluation to dotnet msbuild -getItem. |
| tools/Download-NuGetPackage.ps1 | Uses ToLowerInvariant() for stable, culture-invariant package ID normalization. |
| tools/Convert-PDB.ps1 | Uses Join-Path for building the Pdb2Pdb tool path. |
| global.json | Updates .NET SDK version to 10.0.300. |
| Directory.Packages.props | Bumps Microsoft Testing Platform version to 2.2.2. |
| .gitignore | Ignores C# Dev Kit cache files (*.lscache). |
| .github/skills/update-library-template/template-release-notes.md | Adds template release notes to guide future merges. |
| .github/skills/update-library-template/SKILL.md | Defines the update-library-template skill and updates merge instructions/reference link. |
| .config/dotnet-tools.json | Updates dotnet tool versions (PowerShell, nerdbank.dotnetrepotools). |
RyanToth3
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SupportsShouldProcessfromGet-ExternalSymbolFiles.ps1dotnet msbuildfor-getItemparametersdotnet symbolcommand to manifestToLowervariant for package IDs