Open
Conversation
Contributor
|
What's blocking it from being int? |
Collaborator
Author
|
@mikebattista I didn't fully explore that rabbit hole, but I think we'll need to change WM_USER and all the NIN_ msgs to int and then fix all the collateral damage. 😅 |
Collaborator
Author
|
Interesting, made the change locally again and doesn't seem as bad. Will update this PR shortly. |
Collaborator
Author
|
Looks like AzDO has given up on builds. @mikebattista |
Contributor
|
All the other WM_ constants are uint. Are there side effects of making WM_USER int but not the others? Feels like this should cause some usability problems somewhere. |
Collaborator
Author
|
Yeah, I think there's a larger "naked constants should default to int not uint" discussion to be had here. |
Contributor
Thanks. I believe it should be fixed now. |
riverar
force-pushed
the
rafael/notifyicon_msgs
branch
from
01f35c4 to
579cc3e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #1765