Add NativeAnnotationAttribute to the metadata file#2001
Open
dpaoliello wants to merge 1 commit intomicrosoft:mainfrom
Open
Add NativeAnnotationAttribute to the metadata file#2001dpaoliello wants to merge 1 commit intomicrosoft:mainfrom
dpaoliello wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Contributor
|
Is this wired up end-to-end? Are we using a version of clangsharp that emits this? Were there any changes to the baseline? |
Contributor
Author
|
I stumbled on this when I tried to update the version of ClangSharp we were using internally - not sure if this is being used end-to-end or is in the baseline (I honestly don't know how to check). |
Collaborator
|
Just ran into this myself now. Had |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ClangSharp has recently started emitting the
NativeAnnotationattribute for C++annotateattributes: dotnet/ClangSharp#552This PR adds the definition of
NativeAnnotationAttributeto metadata.cs.