Open
Conversation
Author
|
@microsoft-github-policy-service agree |
riverar
previously approved these changes
Sep 1, 2025
Comment on lines
+488
to
+491
| // | ||
| // use the Win32 API instead | ||
| // CreateNamedPipeA | ||
| // |
Collaborator
There was a problem hiding this comment.
This comment won't bubble up anywhere useful so you can delete it.
riverar
approved these changes
Sep 10, 2025
jonwis
approved these changes
Oct 28, 2025
jevansaks
reviewed
Oct 29, 2025
| // | ||
| __kernel_entry NTSTATUS | ||
| NTAPI | ||
| NtCreateNamedPipeFile( |
Member
There was a problem hiding this comment.
Won't this file get clobbered the next time we run UpdateSDK with whatever is really in the SDK?
is this function definition available in a Windows SDK header that we could use / include instead?
Collaborator
There was a problem hiding this comment.
Docs say it lives in ntioapi.h which isn't public. Agree, we should minimally move it to a new header (e.g., \generation\WinSDK\AdditionalHeaders\ntioapi.h)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
NtCreateNamedPipeFile(https://learn.microsoft.com/en-us/windows/win32/devnotes/nt-create-named-pipe-file) to the list of available binding signatures, this function is used to provide support for asynchronous access for pseudo-terminals via ConHost: https://github.com/microsoft/terminal/blob/2d64a3a4ab0d0d1c5b9085a022f5319460ef68d7/src/types/utils.cpp#L851