Annotate DbgEng/DbgModel APIs that can return S_FALSE with CanReturnMultipleSuccessValues.#2216
Open
takubokudori wants to merge 2 commits intomicrosoft:mainfrom
Open
Annotate DbgEng/DbgModel APIs that can return S_FALSE with CanReturnMultipleSuccessValues.#2216takubokudori wants to merge 2 commits intomicrosoft:mainfrom
takubokudori wants to merge 2 commits intomicrosoft:mainfrom
Conversation
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since these DbgEng/DbgModel APIs may return S_OK and S_FALSE, they should be annotated with CanReturnMultipleSuccessValues.
GetOutputLinePrefix(Wide), GetEventFilterCommand(Wide), and GetEventFilterText(Wide) do not mention S_FALSE in the documentation, but they may return S_FALSE.
Like other APIs, they return S_FALSE when BufferSize is not big enough.
References:
https://learn.microsoft.com/en-us/windows-hardware/drivers/ddi/dbgeng/
https://learn.microsoft.com/en-us/windows-hardware/drivers/ddi/dbgmodel/