Reinitialize mixer after StopTransport#104
Open
FrayxRulez wants to merge 1 commit intomicrosoft:masterfrom
Open
Reinitialize mixer after StopTransport#104FrayxRulez wants to merge 1 commit intomicrosoft:masterfrom
FrayxRulez wants to merge 1 commit intomicrosoft:masterfrom
Conversation
jlautman
reviewed
Jan 5, 2021
| CloseHandle(_hThread); | ||
| _hThread = nullptr; | ||
| _transporting = false; | ||
| _transportInitialized = false; |
There was a problem hiding this comment.
Can these be set to false on line 630 to avoid setting the same value in two places? Or would that introduce a potential race condition?
Contributor
Author
There was a problem hiding this comment.
I feel that there's the risk of a race condition, as if you see _transporting was set to false in both places even before my change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current implementation doesn't allow to change render/capture device after the transport has been initialized.
This PR aims to fix the issue.
I've been looking around for additional stuff to be disposed/released, but I couldn't find any.
A possible improvement to this code would be to move this code to
SetDevicemethod, and onlyif (!Transporting()).This way, Stopping and Starting the transport without changing device won't cause a useless reinitialization.
Since in my code base we only stop/start the transports when switching devices, I consider this fine or me.