fix: correct order-service image name typo (ordr-service → order-service)#18
Closed
github-actions[bot] wants to merge 1 commit intomainfrom
Closed
Conversation
…ice) Fixes typo introduced in commit e5c5ea5. The order-service container image was incorrectly set to 'ordr-service:2.1.0' (missing 'e'). This caused the order-service deployment to fail pulling the non-existent image, leaving the new pod stuck in Init:0/1 (waiting for RabbitMQ while using wrong image). Fixes: DevExpGbb#17 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes image name typo in
Act-3/argocd/apps/broken-aks-store-all-in-one.yamlthat was introduced in commite5c5ea5.Closes DevExpGbb#17
Root Cause Analysis
The ArgoCD app
agentic-platform-engineering-demowas marked Degraded due to cascading failures from two image name typos introduced in recent commits:Bug 1 — RabbitMQ image typo (already fixed in
e5c5ea5)38055faintroduced:mcr.microsoft.com/azurelinux/base/rabitmq-server:3.13(singleb)e5c5ea5corrected back to:mcr.microsoft.com/azurelinux/base/rabbitmq-server:3.13rabbitmq-0pod was created with the broken image, causingImagePullBackOff. StatefulSet spec has been corrected; pod was manually deleted to trigger recreation with the correct image.Bug 2 — order-service image typo (fixed by this PR)
e5c5ea5introduced:ghcr.io/azure-samples/aks-store-demo/ordr-service:2.1.0(missinge)ghcr.io/azure-samples/aks-store-demo/order-service:2.1.0order-servicepod (9fc4bb856) stuck inInit:0/1(init container waiting for RabbitMQ, then would fail image pull)Cascading Failure
With RabbitMQ down,
makeline-serviceloses its AMQP connection and returnsHTTP 500on/order/fetch, causingvirtual-workerto crash withCrashLoopBackOff.Changes
Act-3/argocd/apps/broken-aks-store-all-in-one.yamlordr-service:2.1.0→order-service:2.1.0(line 196)Test Plan
selfHeal: true)order-servicedeployment rolls out with new ReplicaSetkubectl get pods -n default # Expected: rabbitmq-0 Running, order-service Running, virtual-worker RunningHealthyRollback