Removing unwanted tabs

[renemadsen]

No description provided.

[Copilot]

Pull request overview

This PR removes the shift-specific tabs from the assigned-site dialog in the time-planning plugin. In the current codebase, that dialog is where site-level planned shift schedules are configured, so these template changes directly affect how managers define working time behavior for assigned employees.

Changes:

• Removed the 1st–5th shift tabs from AssignedSiteDialogComponent.
• Left the General, Plan hours, and Auto break calculation settings tabs intact.
• Simplified the dialog UI, but at the cost of removing existing shift-editing surfaces.

Comments suppressed due to low confidence (3)

eform-client/src/app/plugins/modules/time-planning-pn/components/plannings/time-planning-actions/assigned-site/assigned-site-dialog.component.html:336

• Removing all shift tabs leaves no UI path to edit planned shift times when useOnlyPlanHours is false. The form and save logic still rely on the first/second/third/fourth/fifth shift fields, so for the default configuration users can no longer enter or update start/end/break values for a site at all.

    class="btn-primary btn-primary--icon-left"
    id="saveButton"
    (click)="updateAssignedSite()"
    [mat-dialog-close]="data">

eform-client/src/app/plugins/modules/time-planning-pn/components/plannings/time-planning-actions/assigned-site/assigned-site-dialog.component.html:336

• This change also removes the only UI for the optional 3rd/4th/5th shifts. The "Enable third/fourth/fifth shift" checkboxes in the General tab still remain, but once one of those flags is turned on there is nowhere left in the dialog to configure that extra shift's schedule.

    class="btn-primary btn-primary--icon-left"
    id="saveButton"
    (click)="updateAssignedSite()"
    [mat-dialog-close]="data">

eform-client/src/app/plugins/modules/time-planning-pn/components/plannings/time-planning-actions/assigned-site/assigned-site-dialog.component.html:336

• There are many unit tests for this component's form state, but none exercise the rendered tab set. Because of that, removing all shift tabs is currently untested and a regression like this can ship without failing CI. Please add a template-level test that asserts which tabs are available for useOnlyPlanHours and the shift flags.

    class="btn-primary btn-primary--icon-left"
    id="saveButton"
    (click)="updateAssignedSite()"
    [mat-dialog-close]="data">

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.