feat: generic session keys & session pallet migration of PR 1105 by Klapeyron · Pull Request #1802 · midnightntwrk/midnight-node

Klapeyron · 2026-07-01T10:16:35Z

Overview

🗹 TODO before merging

Ready

📌 Submission Checklist

All commits are signed off (git commit -s) for the DCO
Changes are backward-compatible (or flagged if breaking)
Pull request description explains why the change is needed
Self-reviewed the diff
I have included a change file, or skipped for this reason:
If the changes introduce a new feature, I have bumped the node minor version
Update documentation (if relevant)
Updated AGENTS.md if build commands, architecture, or workflows changed
No new todos introduced

🧪 Testing Evidence

Please describe any additional testing aside from CI:

Additional tests are provided (if possible)

🔱 Fork Strategy

Node Runtime Update
Node Client Update
Other:
N/A

Links

LGLO · 2026-07-07T12:54:30Z


 ## Added

+* Added `partner-chains-node smart-contracts upsert-script` command for inserting and updating versioned scripts.


Seems redundant

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 36e8f43bbc

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-07-08T07:45:23Z

+//!
+//! impl From<LegacyAuthorityKeys> for SessionKeys {
+//! 	fn from(old: LegacyAuthorityKeys) -> Self {
+//! 		SessionKeys { aura: old.aura, grandpa: old.grandpa, beefy: ecdsa::Public::default().into() }


Use per-validator placeholders for added keys

When this example is followed for an upgrade that adds Beefy, every validator is assigned the same default Beefy key. pallet_session::upgrade_keys rewrites KeyOwner for each new key, so a shared added key leaves ownership pointing at whichever validator is processed last, and the migration's try-runtime checks currently skip newly added key types. Use a deterministic per-validator placeholder/derived key in the example, or explicitly require uniqueness, so chains do not copy a migration that corrupts new-key ownership.

Useful? React with 👍 / 👎.

Signed-off-by: Tomasz Bartos <tomasz.bartos@shielded.io>

Two gaps between upstream's partner-chains pallet-session version and the polkadot-stable2603 one pinned in midnight-node's workspace: - pallet_session::Config requires Currency/KeyDeposit associated types under stable2603; upstream's version at the time of this PR didn't need them yet. Added to committee-selection/pallet's own mock.rs (demo/runtime's mock and the pallet itself already had this fixed by the squash commit; this pallet mock.rs still needed it). - pretty_assertions dev-dependency missing from demo/runtime/Cargo.toml. Assisted-by: Claude:claude-sonnet-4-6 Signed-off-by: Tomasz Bartos <tomasz.bartos@shielded.io>

Signed-off-by: Tomasz Bartos <tomasz.bartos@shielded.io>

…n; wire pallet_session historical bypass for automatic key registration PR #1025 deletes the pallet-partner-chains-session crate from partner-chains/, which midnight-node's own runtime and node depend on directly (outside the partner-chains/ subtree). Migrate to the same approach used within partner-chains/demo/runtime: wire pallet_session::Config directly, with ShouldEndSession/SessionManager delegated to SessionCommitteeManagement (pallet_session_validator_management), which implements them via pallet_session_support.rs. - runtime/src/lib.rs, mock.rs: replace impl_pallet_session_config! macro and the old dual PalletSession(stub)+Session(real) pallet setup with a single pallet_session::Config impl wired to SessionCommitteeManagement. Removes the now-dead session_manager module (ValidatorManagementSessionManager), whose role is filled directly by the committee-selection pallet. - node/src/chain_spec/mod.rs: update genesis construction for pallet_session's real GenesisConfig{keys, non_authority_keys} shape; drop the leftover PalletSessionConfig field for the removed stub pallet. - Cargo.toml, runtime/Cargo.toml: drop the pallet-partner-chains-session dependency. Separately, PR #1026's automatic key registration (pallet_session_support.rs's register_committee_keys) dispatches pallet_session::set_keys with an empty ownership proof. That's a no-op against upstream's pinned polkadot-stable2509, where OpaqueKeys::ownership_proof_is_valid defaults to true, but our workspace pins polkadot-stable2603, where impl_opaque_keys! generates a real proof-of-possession check, so every automatic registration silently failed (the error is logged, not propagated). polkadot-stable2603 added pallet_session::SessionInterface specifically for this: privileged/internal callers can set keys without an ownership proof, since the caller (not the extrinsic sender) already vouches for the keys. Wire it up: - pallet_session_support.rs: require T: pallet_session::historical::Config (SessionInterface is implemented for Pallet<T> only when historical::Config is also satisfied) and call SessionInterface::set_keys directly instead of dispatching the set_keys extrinsic with an empty proof. - Root Cargo.toml: enable pallet-session's historical feature. - runtime/src/lib.rs, mock.rs, demo/runtime/src/lib.rs, mock.rs, and the committee-selection pallet's own mock.rs: add the Historical pallet to construct_runtime! and implement historical::Config with a trivial FullIdentification = () (we don't use its NPoS/slashing features, only the SessionInterface bypass). - runtime/src/lib.rs tests (check_aura_authorities_rotation, check_grandpa_authorities_rotation): update to the corrected 2-epoch committee-application delay, mirroring partner-chains/demo/runtime's already-updated tests. Real pallet_session's queue-then-apply model adds one full epoch of lag versus the old pallet-partner-chains-session behavior (PR #1038 later reduces this back down). Assisted-by: Claude:claude-sonnet-4-6 Signed-off-by: Tomasz Bartos <tomasz.bartos@shielded.io>

Session set_keys/purge_keys must not be dispatchable; committee keys are registered automatically from Cardano registrations via the session manager. Signed-off-by: Tomasz Bartos <tomasz.bartos@shielded.io>

Signed-off-by: Tomasz Bartos <tomasz.bartos@shielded.io>

…1038) Signed-off-by: Tomasz Bartos <tomasz.bartos@shielded.io>

…mittee rotation PR #1038 adds an additional session immediately after an epoch-triggered rotation, collapsing the 1-extra-epoch lag from real pallet_session's queue-then-apply model down to roughly 1 extra block. Update check_aura_authorities_rotation and check_grandpa_authorities_rotation in runtime/src/lib.rs to the corrected timing, mirroring the pattern already present in partner-chains/demo/runtime/src/lib.rs's own (upstream-updated) tests for the same PR. Signed-off-by: Tomasz Bartos <tomasz.bartos@shielded.io>

Signed-off-by: Tomasz Bartos <tomasz.bartos@shielded.io>

…ement pallet (#1105) Signed-off-by: Tomasz Bartos <tomasz.bartos@shielded.io>

…ith midnight-node's runtime Signed-off-by: Tomasz Bartos <tomasz.bartos@shielded.io>

…align with midnight-node's runtime Signed-off-by: Tomasz Bartos <tomasz.bartos@shielded.io>

chatgpt-codex-connector · 2026-07-08T13:45:38Z

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

Klapeyron self-assigned this Jul 1, 2026

This comment has been minimized.

Sign in to view

Klapeyron force-pushed the feat/pc-pr-1038 branch from e23cb20 to 416fae4 Compare July 1, 2026 11:45

Klapeyron force-pushed the feat/pc-pr-1105 branch 2 times, most recently from 0faf3d6 to 64e096b Compare July 1, 2026 12:40

Klapeyron force-pushed the feat/pc-pr-1038 branch from 416fae4 to 859dce2 Compare July 6, 2026 08:37

Klapeyron force-pushed the feat/pc-pr-1105 branch 2 times, most recently from 6159020 to bdfa554 Compare July 6, 2026 09:08

Klapeyron force-pushed the feat/pc-pr-1038 branch from 5fd4ffe to cea9145 Compare July 6, 2026 09:31

Klapeyron force-pushed the feat/pc-pr-1105 branch 2 times, most recently from a70b538 to f8ddf13 Compare July 6, 2026 10:09

Klapeyron force-pushed the feat/pc-pr-1038 branch from ab415db to 09bae27 Compare July 6, 2026 10:10

Klapeyron force-pushed the feat/pc-pr-1105 branch from f8ddf13 to c8769f1 Compare July 6, 2026 10:10

Klapeyron force-pushed the feat/pc-pr-1038 branch from 09bae27 to 8d6f574 Compare July 6, 2026 10:27

Klapeyron force-pushed the feat/pc-pr-1105 branch from c8769f1 to 7e0ee9a Compare July 6, 2026 10:28

Klapeyron added the skip-changes-check-all label Jul 6, 2026

Klapeyron force-pushed the feat/pc-pr-1038 branch from 8d6f574 to b2cdd43 Compare July 6, 2026 10:35

Klapeyron force-pushed the feat/pc-pr-1105 branch from 7e0ee9a to 87b7696 Compare July 6, 2026 10:35

Klapeyron force-pushed the feat/pc-pr-1038 branch from b2cdd43 to fdde417 Compare July 6, 2026 11:07

Klapeyron force-pushed the feat/pc-pr-1105 branch from 87b7696 to 4c09ae9 Compare July 6, 2026 12:46

Klapeyron force-pushed the feat/pc-pr-1038 branch from fdde417 to 3a22652 Compare July 7, 2026 12:43

Klapeyron force-pushed the feat/pc-pr-1105 branch from 4c09ae9 to 5c81892 Compare July 7, 2026 12:44

LGLO reviewed Jul 7, 2026

View reviewed changes

Klapeyron force-pushed the feat/pc-pr-1038 branch from 3a22652 to eb8cedb Compare July 8, 2026 06:37

Klapeyron force-pushed the feat/pc-pr-1105 branch from 5c81892 to 36e8f43 Compare July 8, 2026 06:37

This was linked to issues Jul 8, 2026

[Aura→BABE] SPK-02 (spike) — Session-key carrier decision #1759

Open

[Aura→BABE] RT-05 — AuthorityKeys idempotent storage migration #1744

Open

Klapeyron removed a link to an issue Jul 8, 2026

[Aura→BABE] SPK-02 (spike) — Session-key carrier decision #1759

Open

Klapeyron marked this pull request as ready for review July 8, 2026 07:38

Klapeyron requested a review from a team as a code owner July 8, 2026 07:38

Base automatically changed from feat/pc-pr-1038 to feat/pc-pr-1026 July 8, 2026 07:39

chatgpt-codex-connector Bot reviewed Jul 8, 2026

View reviewed changes

AmbientTea and others added 20 commits July 8, 2026 14:53

change: Automatic key registration (#1026)

15a3b46

Signed-off-by: Tomasz Bartos <tomasz.bartos@shielded.io>

chore: review changes

177e69f

Signed-off-by: Tomasz Bartos <tomasz.bartos@shielded.io>

remove: pallet-partner-chains-session (#1025)

7314b45

Signed-off-by: Tomasz Bartos <tomasz.bartos@shielded.io>

fix: disable pallet_session extrinsics in midnight runtime

3dcdc08

Session set_keys/purge_keys must not be dispatchable; committee keys are registered automatically from Cardano registrations via the session manager. Signed-off-by: Tomasz Bartos <tomasz.bartos@shielded.io>

docs: mention runtime::disable_call for pallet_session extrinsics

16a10aa

Signed-off-by: Tomasz Bartos <tomasz.bartos@shielded.io>

feat: removed genesis keys registration via session pallet

2fb1e4a

Signed-off-by: Tomasz Bartos <tomasz.bartos@shielded.io>

chore: fix CI

48ab7ce

Signed-off-by: Tomasz Bartos <tomasz.bartos@shielded.io>

chore: regenerated metadata

cc3563f

Signed-off-by: Tomasz Bartos <tomasz.bartos@shielded.io>

remove: pallet-partner-chains-session (#1025)

82022ce

Signed-off-by: Tomasz Bartos <tomasz.bartos@shielded.io>

Start an additional session to accelerate usage of the new committee (#…

2d45181

…1038) Signed-off-by: Tomasz Bartos <tomasz.bartos@shielded.io>

chore: fix CI

637824c

Signed-off-by: Tomasz Bartos <tomasz.bartos@shielded.io>

chore: fix tests

5da3a5d

Signed-off-by: Tomasz Bartos <tomasz.bartos@shielded.io>

feat: removed additional session schedule

8413d04

Signed-off-by: Tomasz Bartos <tomasz.bartos@shielded.io>

chore: regenerated metadata

2e1af40

Signed-off-by: Tomasz Bartos <tomasz.bartos@shielded.io>

add: Reusable AuthorityKeys type migration in session-validator-manag…

d8385d5

…ement pallet (#1105) Signed-off-by: Tomasz Bartos <tomasz.bartos@shielded.io>

chore: rework AuthorityKeysMigration as a VersionedMigration, align w…

23bae41

…ith midnight-node's runtime Signed-off-by: Tomasz Bartos <tomasz.bartos@shielded.io>

fixup! chore: rework AuthorityKeysMigration as a VersionedMigration, …

7157802

…align with midnight-node's runtime Signed-off-by: Tomasz Bartos <tomasz.bartos@shielded.io>

Klapeyron force-pushed the feat/pc-pr-1105 branch from 36e8f43 to 7157802 Compare July 8, 2026 13:45

justinfrevert approved these changes Jul 8, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: generic session keys & session pallet migration of PR 1105#1802

feat: generic session keys & session pallet migration of PR 1105#1802
Klapeyron wants to merge 20 commits into
feat/pc-pr-1026from
feat/pc-pr-1105

Klapeyron commented Jul 1, 2026

Uh oh!

This comment has been minimized.

LGLO Jul 7, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Jul 8, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jul 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants


		## Added

		* Added `partner-chains-node smart-contracts upsert-script` command for inserting and updating versioned scripts.

Uh oh!

Conversation

Klapeyron commented Jul 1, 2026

Overview

🗹 TODO before merging

📌 Submission Checklist

🧪 Testing Evidence

🔱 Fork Strategy

Links

Uh oh!

This comment has been minimized.

LGLO Jul 7, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jul 8, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot commented Jul 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants