This repository was archived by the owner on Jan 25, 2024. It is now read-only.
Fallthrough to embedded responsewriter's httpFlusher interface - #53
Open
Rhionin wants to merge 1 commit into
Open
Fallthrough to embedded responsewriter's httpFlusher interface#53Rhionin wants to merge 1 commit into
Rhionin wants to merge 1 commit into
Conversation
Collaborator
|
@Rhionin what's the error that you see without this fix? |
|
@Rhionin log error example ? |
Author
|
Hi, sorry for the long delay in replying. The error I see is that flushing the response buffer silently gets stuck at this misleading middleware, because it wraps the original response writer and makes the Flush interface become unavailable. I was encountering this when proxying server-sent events (SSE) through a caddy instance |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This plugin breaks server-sent events proxying through caddy, because it breaks the httpFlusher interface and makes responses hang with a buffer. This change implements httpFlusher on the timedResponseWriter as a fallthrough to the embedded responsewriter, or no-op if unavailable.