This repository was archived by the owner on Nov 27, 2025. It is now read-only.
fix: use direct TTL field access instead of pointer arithmetic#20
Open
diegonix wants to merge 1 commit intomiekg:masterfrom
Open
fix: use direct TTL field access instead of pointer arithmetic#20diegonix wants to merge 1 commit intomiekg:masterfrom
diegonix wants to merge 1 commit intomiekg:masterfrom
Conversation
Modern libunbound (1.4.20+) has a direct 'ttl' field in struct ub_result. The previous pointer arithmetic approach was fragile and often returned 0. This fix directly accesses r->ttl which is reliable and safe. Fixes TTL=0 issue with libunbound 1.19.2 and other modern versions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modern libunbound (1.4.20+) has a direct 'ttl' field in struct ub_result.
The previous pointer arithmetic approach was fragile and often returned 0.
This fix directly accesses r->ttl which is reliable and safe.
Fixes TTL=0 issue with libunbound 1.19.2 and other modern versions.
Tested with libunbound 1.19.2 on Ubuntu 24.04.