Skip to content

Artemis: feat: Improve TaskType.fromString performance using cache #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mike-turintech wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Artemis: feat: Improve TaskType.fromString performance using cache #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 17 additions & 6 deletions src/main/java/com/llmproxy/model/TaskType.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
package com.llmproxy.model;

import java.util.Map;
import java.util.HashMap;

public enum TaskType {
TEXT_GENERATION("text_generation"),
SUMMARIZATION("summarization"),
Expand All @@ -9,6 +12,15 @@ public enum TaskType {

private final String value;

// Cache for fromString method to improve performance
private static final Map<String, TaskType> STRING_TO_ENUM_MAP = new HashMap<>();

static {
for (TaskType type : values()) {
STRING_TO_ENUM_MAP.put(type.value.toLowerCase(), type);
}
}

TaskType(String value) {
this.value = value;
}
Expand All @@ -18,16 +30,15 @@ public String getValue() {
}

public static TaskType fromString(String text) {
for (TaskType type : TaskType.values()) {
if (type.value.equalsIgnoreCase(text)) {
return type;
}
if (text == null) {
return OTHER; // Or throw IllegalArgumentException, depending on desired behavior
}
return OTHER;
TaskType type = STRING_TO_ENUM_MAP.get(text.toLowerCase());
return type != null ? type : OTHER;
}

@Override
public String toString() {
return value;
}
}
}