Bugfix - relHooks is sometimes undefined (closes #9)#11
Open
nabilfreeman wants to merge 1 commit intomikec:masterfrom
Open
Bugfix - relHooks is sometimes undefined (closes #9)#11nabilfreeman wants to merge 1 commit intomikec:masterfrom
nabilfreeman wants to merge 1 commit intomikec:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#9 - when loading nested relations, relHooks is used in a dynamic function - but sometimes, when that dynamic function is called, relHooks is undefined and everything breaks.
I'm not sure what the cause of this is because of my lack of deep understanding of Kalamata, but I patched it and was able to restore functionality.
@mikec would appreciate you taking a look at this!