fix(checkoutservice): Option 1 — Replace insecure gRPC with system CA TLS#2
Open
mikecstone wants to merge 1 commit into
Open
fix(checkoutservice): Option 1 — Replace insecure gRPC with system CA TLS#2mikecstone wants to merge 1 commit into
mikecstone wants to merge 1 commit into
Conversation
Replaces grpc.WithInsecure() on all 8 service connections with credentials.NewClientTLSFromCert(nil, "") to enforce TLS using the system root CA pool. Also fixes context.TODO() -> ctx in convertCurrency to restore proper timeout and cancellation propagation. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
OX Security reviewed this pull request — nothing to fix.
Branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
grpc.WithInsecure()calls withcredentials.NewClientTLSFromCert(nil, ""), which uses the system root CA pool to validate server certificatescontext.TODO()→ctxinconvertCurrencyto restore proper timeout and cancellation propagationTrade-offs
Pros:
Cons:
When to use this
Best fit if your services run behind a managed load balancer or service mesh that already handles cert issuance, and you need a fast, low-friction fix.
Test plan
PlaceOrderend-to-end works after the change🤖 Generated with Claude Code