fix(checkoutservice): Option 2 — Mutual TLS (mTLS) with custom certs#3
Open
mikecstone wants to merge 1 commit into
Open
fix(checkoutservice): Option 2 — Mutual TLS (mTLS) with custom certs#3mikecstone wants to merge 1 commit into
mikecstone wants to merge 1 commit into
Conversation
Adds loadTLSCredentials() which loads a CA cert, client cert, and client key from environment variables (TLS_CA_CERT_PATH, TLS_CLIENT_CERT_PATH, TLS_CLIENT_KEY_PATH) and configures TLS 1.3 mTLS. The credentials are stored on checkoutService and used for all 8 service connections, removing grpc.WithInsecure() entirely. Also fixes context.TODO() -> ctx in convertCurrency to restore proper timeout/cancellation propagation. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
OX Security reviewed this pull request — nothing to fix.
Branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
loadTLSCredentials()which reads a CA cert, client cert, and client key from environment variables (TLS_CA_CERT_PATH,TLS_CLIENT_CERT_PATH,TLS_CLIENT_KEY_PATH) and configures TLS 1.3 mTLScheckoutServicestruct and uses them for all 8 outbound service connectionsgrpc.WithInsecure()entirelycontext.TODO()→ctxinconvertCurrencyTrade-offs
Pros:
Cons:
Required environment variables
TLS_CA_CERT_PATHTLS_CLIENT_CERT_PATHTLS_CLIENT_KEY_PATHWhen to use this
Best fit for production environments with a zero-trust posture, an internal PKI (e.g. cert-manager, Vault PKI), and where all microservices are being hardened together.
Test plan
PlaceOrderend-to-end succeeds with valid mTLS certs🤖 Generated with Claude Code