fix(loadgenerator): remove hardcoded credit card credentials#7
Open
mikecstone wants to merge 1 commit into
Open
fix(loadgenerator): remove hardcoded credit card credentials#7mikecstone wants to merge 1 commit into
mikecstone wants to merge 1 commit into
Conversation
Replaces hardcoded card number, CVV, and expiry with os.environ.get() calls that fall back to industry-standard test values (4111-1111-1111-1111 is the universally recognised Visa test card used by Stripe, PayPal, etc.). Sensitive values can now be injected at runtime via environment variables without ever touching source control. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
OX Security reviewed this pull request — nothing to fix.
Branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
4432-8015-6152-0454), CVV (672), and expiry fromlocustfile.pyos.environ.get()calls that fall back to universally recognised test valuesWhy
Hardcoded payment credentials in source code are flagged by secret scanning tools (GitHub Advanced Security, GitGuardian, etc.) and represent a real risk if the repo is ever made public or accessed by an unauthorised party. Even if the card is not real, a real-looking number, CVV, and future expiry date in source control is bad practice and will trip secret scanners.
4111-1111-1111-1111is the industry-standard Visa test card number (Luhn-valid, recognised by Stripe, PayPal, Adyen, and most payment processors as a test value).000is a clearly fake CVV.Environment variables (all optional)
LOAD_GEN_CC_NUMBER4111-1111-1111-1111LOAD_GEN_CC_EXPIRY_MONTH1LOAD_GEN_CC_EXPIRY_YEAR2030LOAD_GEN_CC_CVV000Test plan
grep -r '4432' src/loadgenerator/should return nothing)🤖 Generated with Claude Code