Skip to content

Clean up failed cloud computer provisioning - #155

Merged
milind-soni merged 1 commit into
mainfrom
codex/box-provision-rollback
Aug 16, 2026
Merged

Clean up failed cloud computer provisioning#155
milind-soni merged 1 commit into
mainfrom
codex/box-provision-rollback

Conversation

@milind-soni

Copy link
Copy Markdown
Owner

Summary

  • fail immediately when a new cloud computer cannot be named
  • treat readiness, bootstrap, and desktop-link failures as provisioning failures
  • permanently remove only the machine created by the failing attempt
  • preserve pre-existing machines on every later failure path
  • surface a manual cleanup warning and exact box ID if automatic deletion itself fails

The cleanup request follows the provider's current permanent-delete contract, including the exact-ID confirmation header.

Verification

  • pnpm test (452 passed, 8 skipped; updater tests 11 passed)
  • pnpm build
  • provider-contract tests cover cleanup after a failed rename and non-cleanup of an existing machine

Merge order

This is stacked on #154. Merge #151, #153, #154, then this PR.

@coderabbitai

coderabbitai Bot commented Aug 16, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@milind-soni, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 39 minutes

Limit details: You’ve used all 3 included reviews currently available under your plan.

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: e4094c80-383c-444d-b5a2-5a79bc2a8b14

📥 Commits

Reviewing files that changed from the base of the PR and between 2e87128 and 38cda20.

📒 Files selected for processing (2)
  • server/box-provision.test.ts
  • server/box.ts

Comment @coderabbitai help to get the list of available commands.

@milind-soni
milind-soni force-pushed the codex/box-provision-rollback branch from 2dab942 to 68d5866 Compare August 16, 2026 21:08
@milind-soni
milind-soni force-pushed the codex/computer-session-hygiene branch 3 times, most recently from 723f5f9 to 21c5846 Compare August 16, 2026 21:43
@milind-soni
milind-soni force-pushed the codex/box-provision-rollback branch from 68d5866 to 38cda20 Compare August 16, 2026 21:50
@milind-soni
milind-soni changed the base branch from codex/computer-session-hygiene to main August 16, 2026 21:50
@milind-soni
milind-soni marked this pull request as ready for review August 16, 2026 21:50
@milind-soni
milind-soni merged commit 026a179 into main Aug 16, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant