feat(roblox): support React Luau projects with roblox-ts rules#23
feat(roblox): support React Luau projects with roblox-ts rules#23howmanysmall wants to merge 5 commits intomillionco:mainfrom
Conversation
Implement auto-detection for Roblox environments built with roblox-ts. This includes specialized linting configurations that suppress web-specific rules (like DOM/CSS animations and JSX accessibility) while maintaining core React correctness checks. Also adds a `--framework` CLI flag to override automatic detection and improves source file counting for projects not using Git.
… feat/support-react-luau
Introduces four new rules specifically for Roblox development with React: - `rbx-no-uncleaned-connection`: ensures .Connect() in useEffect has cleanup - `rbx-no-print`: warns against print() and warn() in production code - `rbx-no-direct-instance-mutation`: prevents direct assignment to ref.current properties - `rbx-no-unstored-connection`: ensures connections outside of effects are stored These rules are only enabled when the framework is detected as `roblox-ts`. Additionally, `prefer-dynamic-import` is now disabled for Roblox projects as it is not supported by the environment.
|
@howmanysmall is attempting to deploy a commit to the Million Team on Vercel. A member of the Team first needs to authorize it. |
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
| "prepublishOnly": "bun run build" | ||
| }, | ||
| "dependencies": { | ||
| "@rbxts/react": "^17.3.7-ts.1" |
There was a problem hiding this comment.
Test fixture roblox-next-conflict does not contain a next dependency, making the priority test ineffective.
|
Should probably mention that |
Prune the Bun lockfile by removing workspace package definitions and their associated dependency trees. This significantly reduces the size of the lockfile and removes unused dependencies.
1 participant
References
Summary
Adds Roblox/React Luau support with framework detection and a
--frameworkoverride, plus roblox-ts specific lint rules. Updates docs, oxlint config, and test fixtures to validate Roblox-specific behavior.Test Plan