fix(website): prevent hydration mismatch in terminal demo#28
Open
SultokTheF wants to merge 1 commit intomillionco:mainfrom
Open
fix(website): prevent hydration mismatch in terminal demo#28SultokTheF wants to merge 1 commit intomillionco:mainfrom
SultokTheF wants to merge 1 commit intomillionco:mainfrom
Conversation
|
@SultokTheF is attempting to deploy a commit to the Million Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix hydration mismatch on the website terminal demo.
The issue was caused by reading
localStorageduring initial render, which could produce different first render output between SSR and client (empty command on server vs completed command on client).What changed
Terminalnow always starts fromINITIAL_STATEon first render.didAnimationComplete) intouseEffect(client-only after mount).COMPLETED_STATEafter mount.Why this fixes it
SSR and first client render are now deterministic and identical, so React hydration no longer sees text/content mismatch.
Files
packages/website/src/components/terminal.tsxValidation
Additional changes
package-lock.jsonin repo/website gitignore files.