Pass ignore.files patterns to scanning tools#36
Open
Nefleex wants to merge 1 commit intomillionco:mainfrom
Open
Pass ignore.files patterns to scanning tools#36Nefleex wants to merge 1 commit intomillionco:mainfrom
Nefleex wants to merge 1 commit intomillionco:mainfrom
Conversation
|
@Nefleex is attempting to deploy a commit to the Million Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pass
ignore.filesconfig patterns down torunOxlintandrunKnipso excluded files are skipped during scanning, not just filtered from results after the fact.Motivation
The
ignore.filesconfig option is documented and accepted, but it only post-filters diagnostics infilterIgnoredDiagnostics. The scanning tools (oxlint and knip) still process every file regardless. This means projects with large build artifact directories still get hundreds of false positive "unused file" warnings from generated output, even when those paths are configured to be ignored.Usage
{ "ignore": { "files": ["build/**", ".cache/**"] } }With this change, the patterns above are now forwarded to:
--ignore-patternCLI flagscompileGlobPatternutility