fix: improve CLI override/fallback behavior and install/source-count checks#54
Open
Taiki92777 wants to merge 1 commit intomillionco:mainfrom
Open
fix: improve CLI override/fallback behavior and install/source-count checks#54Taiki92777 wants to merge 1 commit intomillionco:mainfrom
Taiki92777 wants to merge 1 commit intomillionco:mainfrom
Conversation
|
@Taiki92777 is attempting to deploy a commit to the Million Team on Vercel. A member of the Team first needs to authorize it. |
This was referenced Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
以下の不具合をまとめて修正しました。
lint/deadCodeをfalseにした場合、CLI からtrueに上書きできないreact-doctor.config.jsonが不正なときに警告が重複して表示されるreact-doctor.config.jsonが不正なときにpackage.jsonのreactDoctorへのフォールバックが効かないinstall-amiがインストール検証前に成功表示してしまう0になる変更内容
--lint/--dead-codeを追加して、boolean 設定の明示的な上書きを可能にしましたscanに事前ロード済み設定を渡せるようにして、同一実行内での重複読み込みを回避しましたreact-doctor.config.jsonが不正でもpackage.json(reactDoctor) へフォールバックするようにしましたinstall-ami実行後にisAmiInstalled()を再評価し、未検出時は成功表示を出さないようにしました動作確認
pnpm --filter react-doctor run test(105 tests passed)--lint --dead-codeによる設定上書きpackage.json設定が適用されることinstall-amiの再検証メッセージCloses #50
Closes #51
Closes #52
Closes #53