feat: add configurable accessibility presets#57
Open
mrharispe wants to merge 2 commits intomillionco:mainfrom
Open
feat: add configurable accessibility presets#57mrharispe wants to merge 2 commits intomillionco:mainfrom
mrharispe wants to merge 2 commits intomillionco:mainfrom
Conversation
|
Someone is attempting to deploy a commit to the Million Team on Vercel. A member of the Team first needs to authorize it. |
Add accessibility option with three presets: - minimal (default): 15 curated high-impact rules - recommended: matches jsx-a11y/recommended preset (31 rules) - strict: matches jsx-a11y/strict preset (33 rules, all as errors) Can be disabled with `accessibility: false`.
ce65144 to
81fa830
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds configurable accessibility presets for jsx-a11y rules, allowing users to choose the level of accessibility linting that fits their project.
Motivation
Previously, react-doctor included a fixed set of 15 accessibility rules. This PR enables users to choose from three presets based on their accessibility requirements:
minimal(default)recommendedjsx-a11y/recommendedpresetstrictjsx-a11y/strictpreset (all rules as errors)Users can also disable accessibility checks entirely by setting
accessibility: false.Usage
Via config file (
react-doctor.config.json){ "accessibility": "recommended" }Via
package.json{ "reactDoctor": { "accessibility": "strict" } }Programmatically
Changes
AccessibilityPresettype ("minimal" | "recommended" | "strict")accessibilityfield toReactDoctorConfigandDiagnoseOptionsoxlint-config.tsrunOxlint,diagnose, andscanto pass accessibility presetTesting
All 137 tests pass, including new tests covering:
false