fix: strip ANSI escape codes from PR comment output#78
Open
k22036 wants to merge 1 commit intomillionco:mainfrom
Open
fix: strip ANSI escape codes from PR comment output#78k22036 wants to merge 1 commit intomillionco:mainfrom
k22036 wants to merge 1 commit intomillionco:mainfrom
Conversation
|
@k22036 is attempting to deploy a commit to the Million Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When react-doctor output is posted as a GitHub PR comment, ANSI color codes (e.g.
\x1b[32m) appear as garbled text because GitHub Markdown does not render ANSI escape sequences.Solution
Pipe the raw output through
sedto strip all ANSI escape sequences before writing to the file used for the PR comment. The terminal output in the Actions log remains unaffected (colors are preserved via the raw file).Changes
action.yml: Save raw output to a temporary file, then produce a clean copy with ANSI codes stripped for use in the PR comment body.・before
・after
