Skip to content

Fix: ignore.files not excluding some project files#91

Open
jordan-sussman wants to merge 1 commit intomillionco:mainfrom
jordan-sussman:main
Open

Fix: ignore.files not excluding some project files#91
jordan-sussman wants to merge 1 commit intomillionco:mainfrom
jordan-sussman:main

Conversation

@jordan-sussman
Copy link

@jordan-sussman jordan-sussman commented Feb 25, 2026

Summary

Addresses #86 by fixing an issue where files listed in ignore.files were not being excluded as expected. Previously, absolute file paths prevented the ignore patterns from matching project-relative globs.

What changed

Updates filter-diagnostics.ts to ensure ignore.files patterns correctly exclude matching project files by normalizing file paths to be relative to the project root.

Files

packages/react-doctor/src/utils/filter-diagnostics.ts

Validation

  • Add or run a test with ignore.files containing a project-relative glob (e.g., resources/js/components/ui/**).
  • Verify that diagnostics from files matching the glob are excluded.
  • Confirm that diagnostics from files not matching the glob still appear.
  • Tests continue passing in filter-diagnostics.test.ts

@vercel
Copy link

vercel bot commented Feb 25, 2026

@jordan-sussman is attempting to deploy a commit to the Million Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant