Fix: ignore.files not excluding some project files#91
Open
jordan-sussman wants to merge 1 commit intomillionco:mainfrom
Open
Fix: ignore.files not excluding some project files#91jordan-sussman wants to merge 1 commit intomillionco:mainfrom
ignore.files not excluding some project files#91jordan-sussman wants to merge 1 commit intomillionco:mainfrom
Conversation
|
@jordan-sussman is attempting to deploy a commit to the Million Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses #86 by fixing an issue where files listed in
ignore.fileswere not being excluded as expected. Previously, absolute file paths prevented the ignore patterns from matching project-relative globs.What changed
Updates
filter-diagnostics.tsto ensureignore.filespatterns correctly exclude matching project files by normalizing file paths to be relative to the project root.Files
packages/react-doctor/src/utils/filter-diagnostics.tsValidation
filter-diagnostics.test.ts