Skip to content

Fix some potential performance defects#445

Merged
sre-ci-robot merged 1 commit intomilvus-io:masterfrom
yhmo:perf
Mar 18, 2026
Merged

Fix some potential performance defects#445
sre-ci-robot merged 1 commit intomilvus-io:masterfrom
yhmo:perf

Conversation

@yhmo
Copy link
Collaborator

@yhmo yhmo commented Feb 13, 2026

No description provided.

Copilot AI review requested due to automatic review settings February 13, 2026 03:53
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yhmo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@mergify mergify bot added the ci-passed label Feb 13, 2026
@codecov
Copy link

codecov bot commented Feb 13, 2026

Codecov Report

❌ Patch coverage is 76.47059% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.06%. Comparing base (a0592aa) to head (0cb5f24).
⚠️ Report is 79 commits behind head on master.

Files with missing lines Patch % Lines
src/impl/utils/FP16.cpp 50.00% 4 Missing ⚠️
src/impl/utils/DqlUtils.cpp 84.21% 3 Missing ⚠️
src/impl/MilvusClientV2Impl.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #445      +/-   ##
==========================================
- Coverage   53.47%   46.06%   -7.42%     
==========================================
  Files          52      235     +183     
  Lines        4432    12381    +7949     
  Branches        0     1241    +1241     
==========================================
+ Hits         2370     5703    +3333     
- Misses       2062     6584    +4522     
- Partials        0       94      +94     
Files with missing lines Coverage Δ
src/impl/types/FieldData.cpp 69.28% <100.00%> (-22.72%) ⬇️
src/impl/utils/CompareUtils.cpp 83.15% <100.00%> (ø)
src/include/milvus/types/ConnectParam.h 100.00% <ø> (ø)
src/impl/MilvusClientV2Impl.cpp 0.00% <0.00%> (ø)
src/impl/utils/DqlUtils.cpp 66.41% <84.21%> (ø)
src/impl/utils/FP16.cpp 78.12% <50.00%> (ø)

... and 246 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 7 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: yhmo <yihua.mo@zilliz.com>
@yhmo yhmo added the lgtm label Mar 18, 2026
@sre-ci-robot sre-ci-robot merged commit c0b3cd7 into milvus-io:master Mar 18, 2026
10 of 12 checks passed
yhmo added a commit to yhmo/milvus-sdk-cpp that referenced this pull request Mar 18, 2026
Signed-off-by: yhmo <yihua.mo@zilliz.com>
sre-ci-robot pushed a commit that referenced this pull request Mar 19, 2026
Signed-off-by: yhmo <yihua.mo@zilliz.com>
@yhmo yhmo deleted the perf branch March 19, 2026 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants