Conversation
Move the tracing::warn! from danger_accept_invalid_certs() into TlsMode::apply, so TlsMode::DangerAcceptInvalid constructed directly also warns. The warning now fires once per built client instead of once per constructed value; a caller reusing one mode across N clients gets N warnings, a caller that never applies it gets none.
Name the openQA-python-client revision the numbers come from and list the three deliberate ruoqa hardening choices (jitter, method restriction, Retry-After handling) that diverge from it, so the name does not read as a full reproduction of any upstream client.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix(tls):TlsMode::applynow logs thetracing::warn!forTlsMode::DangerAcceptInvalid, covering the case where the variant isconstructed directly instead of via
danger_accept_invalid_certs(). Thewarning now fires once per built client rather than once per constructed
value.
docs(policy):RetryPolicy::upstream_compat's rustdoc names theopenQA-python-clientrevision its numbers come from and lists the threedeliberate divergences (full jitter, idempotent-method restriction,
Retry-Afterhandling). No behavior change.Test plan
cargo fmt --checkcargo clippy --all-targets --locked -- -D warningscargo test --lockedcargo check --locked --all-targetscargo deny check