ci: add 10-minute timeout to test jobs - #843
Merged
Merged
Conversation
Prevents hung tests from burning GHA minutes for hours. Tests normally complete in ~90s, so 10 minutes is generous headroom while still failing fast on hangs. Co-Authored-By: Claude <noreply@anthropic.com>
After migration squash (#713), the prior release may have more migrations applied than HEAD ships (HEAD has 1 idempotent baseline; prior had 20). Change the assertion from equality to >= since the baseline is idempotent. Co-Authored-By: Claude <noreply@anthropic.com>
psamiton
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevents hung tests from burning GHA minutes for hours. Tests normally complete in ~90s, so 10 minutes is generous headroom while still failing fast on hangs.
Also fixes the upgrade-e2e migration count assertion that broke after the migration squash (#837). After squash, the prior release has 20 migrations applied but HEAD only ships 1 (the idempotent baseline), so the equality check fails. Changed to >= since the baseline is idempotent.
Adds
timeout-minutes: 10to:testtest-e2etest-upgradeNote
There is still a separate issue with upgrade-e2e: the upgrade conflicts on
.upstream.jsonin skill directories. Filed as #844 — that one needs a fix in the upgrade logic itself.Context
The
testjob on #837 hung for nearly 2 hours before manual cancellation.🤖 Generated with Claude Code