Skip to content

Update the dependency#176

Merged
lionelkusch merged 29 commits intomind-inria:mainfrom
lionelkusch:PR_dependency
Mar 14, 2025
Merged

Update the dependency#176
lionelkusch merged 29 commits intomind-inria:mainfrom
lionelkusch:PR_dependency

Conversation

@lionelkusch
Copy link
Copy Markdown
Collaborator

I updated the dependency for the tests and library. This PR should be reviewed after the PR #166.
I didn't touch the dependency for the examples and the documentation because we needed to clean the examples and work on the documentation before updating them.

@lionelkusch lionelkusch linked an issue Mar 12, 2025 that may be closed by this pull request
@lionelkusch lionelkusch requested a review from bthirion March 12, 2025 16:59
@lionelkusch lionelkusch requested a review from jpaillard March 12, 2025 16:59
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.78%. Comparing base (0973738) to head (4040a7d).
Report is 33 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #176   +/-   ##
=======================================
  Coverage   97.78%   97.78%           
=======================================
  Files          23       23           
  Lines        1127     1127           
=======================================
  Hits         1102     1102           
  Misses         25       25           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@bthirion bthirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx !

Copy link
Copy Markdown
Collaborator

@jpaillard jpaillard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it a good practice to upper-bound dependencies version? Is there not a risk that we forget about it and prevent users from using the latest versions? On the contrary if we don't put a strict maximum version, we don't risk forgetting about it since the CI would break

@lionelkusch
Copy link
Copy Markdown
Collaborator Author

Yes, upper-bound dependencies are a good practice. This practice is proposed as an example in PEP651.
There is not really a risk of preventing a user to not use the latest version of a package because there is always a period to let users change to the new versions. In fact, it's more the opposite; the risk is to let the user to use the latest version, which is not compatible with your library.
If we include a dependency bot, the upgrade to the library will be automatic and we won't forget them (see comments)

However, the break of CI is not a good indicator because the CI will not break for good reason (the actual PR) and it will be applied to only the development version and not to the last release or previous version.

@jpaillard
Copy link
Copy Markdown
Collaborator

Thx for the explanation :)

@lionelkusch lionelkusch merged commit 655c81f into mind-inria:main Mar 14, 2025
@lionelkusch lionelkusch deleted the PR_dependency branch March 14, 2025 12:14
@lionelkusch lionelkusch added the dependencies Pull requests that update a dependency file label Apr 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build should not require Python 3.12

3 participants