Update the dependency#176
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #176 +/- ##
=======================================
Coverage 97.78% 97.78%
=======================================
Files 23 23
Lines 1127 1127
=======================================
Hits 1102 1102
Misses 25 25 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jpaillard
left a comment
There was a problem hiding this comment.
Is it a good practice to upper-bound dependencies version? Is there not a risk that we forget about it and prevent users from using the latest versions? On the contrary if we don't put a strict maximum version, we don't risk forgetting about it since the CI would break
|
Yes, upper-bound dependencies are a good practice. This practice is proposed as an example in PEP651. However, the break of CI is not a good indicator because the CI will not break for good reason (the actual PR) and it will be applied to only the development version and not to the last release or previous version. |
|
Thx for the explanation :) |
I updated the dependency for the tests and library. This PR should be reviewed after the PR #166.
I didn't touch the dependency for the examples and the documentation because we needed to clean the examples and work on the documentation before updating them.