Reformat the gaussian conditional sampler #366
Merged
lionelkusch merged 50 commits intomind-inria:mainfrom Oct 15, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #366 +/- ##
==========================================
- Coverage 99.43% 99.38% -0.06%
==========================================
Files 22 20 -2
Lines 1247 1140 -107
==========================================
- Hits 1240 1133 -107
Misses 7 7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Aug 29, 2025
bthirion
reviewed
Aug 30, 2025
Collaborator
bthirion
left a comment
bthirion
left a comment
There was a problem hiding this comment.
Thx for this refactoring. I have two relatively minor comments.
jpaillard
reviewed
Sep 3, 2025
Collaborator
jpaillard
left a comment
jpaillard
left a comment
There was a problem hiding this comment.
Thanks, I agree that having both samplers implemented as classes makes sense.
jpaillard
reviewed
Sep 4, 2025
jpaillard
reviewed
Sep 4, 2025
jpaillard
reviewed
Sep 4, 2025
Collaborator
jpaillard
left a comment
jpaillard
left a comment
There was a problem hiding this comment.
I think it limits extra work to integrate the test in this PR rather than having to fix something in an upcoming one. I made a suggestion for the tests.
Co-authored-by: Joseph Paillard <joseph.paillard@inria.fr>
Co-authored-by: Joseph Paillard <joseph.paillard@inria.fr>
bthirion
reviewed
Sep 5, 2025
Collaborator
bthirion
left a comment
bthirion
left a comment
There was a problem hiding this comment.
The PR is almost ready to merge
Co-authored-by: bthirion <bertrand.thirion@inria.fr>
jpaillard
previously approved these changes
Sep 5, 2025
bthirion
reviewed
Oct 12, 2025
Collaborator
bthirion
left a comment
bthirion
left a comment
There was a problem hiding this comment.
Needs a bit of fine tuning.
Co-authored-by: bthirion <bertrand.thirion@inria.fr>
[skip tests]
jpaillard
reviewed
Oct 13, 2025
jpaillard
reviewed
Oct 14, 2025
bthirion
approved these changes
Oct 14, 2025
Collaborator
bthirion
left a comment
bthirion
left a comment
There was a problem hiding this comment.
Given #488, I have no further comments than @jpaillard's ones.
Co-authored-by: Joseph Paillard <joseph.paillard@inria.fr>
Co-authored-by: Joseph Paillard <joseph.paillard@inria.fr>
Co-authored-by: Joseph Paillard <joseph.paillard@inria.fr>
Co-authored-by: Joseph Paillard <joseph.paillard@inria.fr>
jpaillard
approved these changes
Oct 15, 2025
Collaborator
jpaillard
left a comment
jpaillard
left a comment
There was a problem hiding this comment.
Thank you for the changes
This was referenced Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I reformat the Gaussian estimation of knockoff in the format of classes, as conditional sampling.
I moved all the conditional samplers into statistical_tool.