Skip to content

[MAINT] Run sklearn check_estimators on PFI and PFICV#610

Merged
jpaillard merged 5 commits into
mainfrom
sklearn_est_pfi
Feb 26, 2026
Merged

[MAINT] Run sklearn check_estimators on PFI and PFICV#610
jpaillard merged 5 commits into
mainfrom
sklearn_est_pfi

Conversation

@jpaillard
Copy link
Copy Markdown
Collaborator

@jpaillard jpaillard commented Feb 24, 2026

Related to #599
one more estimator from the list in #350

@jpaillard jpaillard requested a review from Remi-Gau February 24, 2026 17:47
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 24, 2026

Codecov Report

❌ Patch coverage is 95.65217% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 98.20%. Comparing base (f75386e) to head (c14fbf0).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/hidimstat/base_perturbation.py 95.65% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #610      +/-   ##
==========================================
+ Coverage   98.06%   98.20%   +0.14%     
==========================================
  Files          23       23              
  Lines        1605     1619      +14     
==========================================
+ Hits         1574     1590      +16     
+ Misses         31       29       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@bthirion bthirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, thx.

Comment thread src/hidimstat/base_perturbation.py
Comment thread test/conftest.py
Comment thread test/test_permutation_feature_importance.py
@jpaillard jpaillard merged commit dab9ff9 into main Feb 26, 2026
13 of 14 checks passed
@jpaillard jpaillard deleted the sklearn_est_pfi branch February 26, 2026 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants