Improve the coverage of the tests and fix some minor bugs#64
Improve the coverage of the tests and fix some minor bugs#64lionelkusch merged 28 commits intomind-inria:mainfrom
Conversation
|
Tis pull request is complementary to the pull request on the estimators #58 and #59 for having coverage close to 99%. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #64 +/- ##
==========================================
+ Coverage 81.70% 84.23% +2.53%
==========================================
Files 43 43
Lines 2312 2449 +137
==========================================
+ Hits 1889 2063 +174
+ Misses 423 386 -37 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bthirion
left a comment
There was a problem hiding this comment.
Thx for taking care of that, this is super important.
Please take care of the syntax aspects.
How much does test time increase with this PR ? We need to be careful to keep it limited.
The time for the tests is still less than 5 min, as you can see in the report below. |
|
8min is still fine, but we must be super careful here, because these numbers increase steadily. |
d19a514 to
369ccdb
Compare
bthirion
left a comment
There was a problem hiding this comment.
The test part looks OK to me.
improvement Co-authored-by: bthirion <bertrand.thirion@inria.fr> Co-authored-by: Joseph Paillard <joseph.paillard@inria.fr>
change position of import Co-authored-by: Joseph Paillard <joseph.paillard@inria.fr>
Formatting the file
|
I finally decided to remove the option for groups and I created the group by hand. |
bthirion
left a comment
There was a problem hiding this comment.
LGTM overall. One more line needs coverage.
|
I removed the line not covered because it will be modified in the PR #132. |
I added in this pull request some simple tests (raise exceptions, used some options ...)
The aim of this pull request is to increase the coverage before starting to make a lot of modifications to the library.
The new tests are simple due to my lack of knowledge of the details of the different methods.
I don't take the time to format and comment on the additional tests; I will do it when I will reformat each method.