MOBILE-281: Replace deviceUUID with MD5 target hash in monitoring logs - #749
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the monitoring “logs” configuration schema to stop transporting raw deviceUUID values and instead use an MD5 “target” hash, then adjusts filtering/validation and tests/resources accordingly.
Changes:
- Renamed monitoring log identifier fields from
deviceUUID/deviceIdtotargetacross DTOs, domain models, mapping, and tests. - Updated device matching logic to compare
targetagainstMD5(lowercased(deviceUuid))(case-insensitive target comparison) and added MD5 test vectors. - Refreshed config-parsing JSON fixtures and added a fixture/test covering legacy
deviceUUIDformat (parses withtarget == null).
Reviewed changes
Copilot reviewed 28 out of 28 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/src/test/resources/ConfigParsing/Monitoring/MonitoringLogsTwoElementsTypeError.json | Updates monitoring log fixtures to use target instead of deviceUUID. |
| sdk/src/test/resources/ConfigParsing/Monitoring/MonitoringLogsTwoElementsError.json | Updates error-case fixture keys to reflect the new target field. |
| sdk/src/test/resources/ConfigParsing/Monitoring/MonitoringLogsOneElementTypeError.json | Updates monitoring log fixtures to use target. |
| sdk/src/test/resources/ConfigParsing/Monitoring/MonitoringLogsOneElementError.json | Updates monitoring log fixtures to use target. |
| sdk/src/test/resources/ConfigParsing/Monitoring/MonitoringLogsOldDeviceUuidFormat.json | Adds legacy-format fixture with deviceUUID to verify backward parsing behavior. |
| sdk/src/test/resources/ConfigParsing/Monitoring/MonitoringLogsError.json | Updates monitoring error fixture to use target. |
| sdk/src/test/resources/ConfigParsing/Monitoring/MonitoringLogsElementsMixedError.json | Updates mixed-error fixture to use target. |
| sdk/src/test/resources/ConfigParsing/Monitoring/MonitoringConfig.json | Updates baseline monitoring config fixture to use target. |
| sdk/src/test/resources/ConfigParsing/ConfigWithSettingsABTestsMonitoringInapps.json | Updates embedded monitoring fixture to use target. |
| sdk/src/test/resources/ConfigParsing/Config/ConfigWithSettingsABTestsMonitoringInapps.json | Updates embedded monitoring fixture to use target. |
| sdk/src/test/resources/ConfigParsing/Config/ConfigSettingsTypeError.json | Updates embedded monitoring fixture to use target. |
| sdk/src/test/resources/ConfigParsing/Config/ConfigSettingsError.json | Updates embedded monitoring fixture to use target. |
| sdk/src/test/resources/ConfigParsing/Config/ConfigMonitoringError.json | Updates embedded monitoring fixture to use target. |
| sdk/src/test/resources/ConfigParsing/Config/ConfigInAppsTypeError.json | Updates embedded monitoring fixture to use target. |
| sdk/src/test/resources/ConfigParsing/Config/ConfigInAppsError.json | Updates embedded monitoring fixture to use target. |
| sdk/src/test/resources/ConfigParsing/Config/ConfigABTestsTypeError.json | Updates embedded monitoring fixture to use target. |
| sdk/src/test/resources/ConfigParsing/Config/ConfigABTestsOneElementTypeError.json | Updates embedded monitoring fixture to use target. |
| sdk/src/test/resources/ConfigParsing/Config/ConfigABTestsOneElementError.json | Updates embedded monitoring fixture to use target. |
| sdk/src/test/resources/ConfigParsing/Config/ConfigABTestsError.json | Updates embedded monitoring fixture to use target. |
| sdk/src/test/java/cloud/mindbox/mobile_sdk/monitoring/MonitoringValidatorTest.kt | Renames/updates validator tests to cover target instead of deviceId. |
| sdk/src/test/java/cloud/mindbox/mobile_sdk/monitoring/LogRequestStub.kt | Updates stubs to populate target. |
| sdk/src/test/java/cloud/mindbox/mobile_sdk/monitoring/domain/managers/LogRequestDataManagerImplTest.kt | Updates filtering tests for hashed target and adds MD5/edge-case coverage. |
| sdk/src/test/java/cloud/mindbox/mobile_sdk/inapp/data/managers/serialization/MonitoringMobileConfigSerializationManagerTest.kt | Adds legacy-format parsing test and updates expectations/comments for new keys. |
| sdk/src/main/java/cloud/mindbox/mobile_sdk/monitoring/domain/models/LogRequest.kt | Renames domain field from deviceId to target. |
| sdk/src/main/java/cloud/mindbox/mobile_sdk/monitoring/domain/managers/LogRequestDataManagerImpl.kt | Implements MD5 hashing and filters logs by hashed device UUID vs target. |
| sdk/src/main/java/cloud/mindbox/mobile_sdk/monitoring/data/validators/MonitoringValidator.kt | Validates target instead of deviceId. |
| sdk/src/main/java/cloud/mindbox/mobile_sdk/models/operation/response/InAppConfigResponse.kt | Updates monitoring DTOs to deserialize target (nullable in blank DTO). |
| sdk/src/main/java/cloud/mindbox/mobile_sdk/inapp/data/mapper/InAppMapper.kt | Maps DTOs/models using the new target field. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
enotniy
reviewed
Jul 31, 2026
| import cloud.mindbox.mobile_sdk.repository.MindboxPreferences | ||
| import java.security.MessageDigest | ||
|
|
||
| internal fun String.md5(): String = MessageDigest.getInstance("MD5") |
Collaborator
There was a problem hiding this comment.
А можно тут заиспользовать value class, типо MD5Hash. И будет прикольно.
Collaborator
Author
There was a problem hiding this comment.
Посмотри, действительно интересно получилось
enotniy
approved these changes
Jul 31, 2026
enotniy
reviewed
Jul 31, 2026
| val requestId: String, | ||
| @SerializedName("deviceUUID") | ||
| val deviceId: String, | ||
| @SerializedName("target") |
Collaborator
There was a problem hiding this comment.
Сериализовать сразу в Md5Hash нельзя?
Или норм, что мы из перехода из Blank делаем
Collaborator
Author
There was a problem hiding this comment.
В целом можно, через кастомный сериализатор. Но тут скорее не нужно кмк, есть StringStrictAdapter уже и мы в Blank сырые данные храним, в потом маппим после валидации в DTO
enotniy
self-requested a review
July 31, 2026 15:01
enotniy
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://tracker.yandex.ru/MOBILE-281