network_ids should be option for basic zones#3
Open
ddoc wants to merge 1 commit intomindjiver:add-initial-support-for-cloudstack-builderfrom
Open
network_ids should be option for basic zones#3ddoc wants to merge 1 commit intomindjiver:add-initial-support-for-cloudstack-builderfrom
ddoc wants to merge 1 commit intomindjiver:add-initial-support-for-cloudstack-builderfrom
Conversation
in basic networking you cannot specify network_ids
Owner
|
Could you update the commit message to look like this: 👍 |
Owner
|
@ddoc Could you do a and use the message above? |
|
I have the same commit ready in one of my branches so if @ddoc doesn't respond, I'm happy to send it to you. |
Owner
|
@petrhosek please do! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
builder/cloudstack: Make network_ids optional
In Cloudstack basic networking it's not possible to specify network_ids, so remove the
hard requirement on specifying this.