fix: Fix bug for attachments without width and height#115
Merged
Conversation
This fixes a bug when PDF thumbnails couldn’t be accessed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes a bug when PDF thumbnails couldn’t be accessed or generated.
In the
image_downsizefilter, we change the logic so that when no width and height is present in the metadata, we bail out of the request and let WordPress handle the request further instead of returning an array with the src, width and height. This makes sense for non-image attachments.With this change, PDF thumbnails can now be accessed using the
wp_get_attachment_image_src()function.