Skip to content

fix(diffusers): update md and fix dtype mismatch of qwenimage#1495

Open
Dong1017 wants to merge 3 commits intomindspore-lab:masterfrom
Dong1017:qwenimage_md
Open

fix(diffusers): update md and fix dtype mismatch of qwenimage#1495
Dong1017 wants to merge 3 commits intomindspore-lab:masterfrom
Dong1017:qwenimage_md

Conversation

@Dong1017
Copy link
Copy Markdown
Contributor

@Dong1017 Dong1017 commented Jan 16, 2026

What does this PR do?

Fixes

  1. Update qwenimage.md: add Qwen-Image-Edit Plus to the md
  2. Fix dtype mismatch in Transformer input under mixed precision: When using mixed precision for different components of the pipeline, the input latent states and prompt embeddings may be in a different dtype than the Transformer's weight dtype (e.g., float16 vs. float32). This mismatch can cause runtime errors during the forward pass. This change ensures that both latents and prompt_embeds are explicitly converted to the Transformer's dtype before being passed into the model.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline?
  • Did you make sure to update the documentation with your changes? E.g. record bug fixes or new features in What's New. Here are the
    documentation guidelines
  • Did you build and run the code without any errors?
  • Did you report the running environment (NPU type/MS version) and performance in the doc? (better record it for data loading, model inference, or training tasks)
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@xxx

@Dong1017 Dong1017 requested a review from vigo999 as a code owner January 16, 2026 09:19
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @Dong1017, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the documentation for the diffusers library by incorporating information about a new variant of the Qwen-Image model, specifically 'Qwen-Image-Edit Plus'. This ensures that the documentation remains current and provides users with comprehensive details on available models and their respective Hugging Face links.

Highlights

  • Documentation Update: Added a new entry for 'Qwen-Image-Edit Plus' to the qwenimage.md documentation, including its Hugging Face repository link.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the documentation for qwenimage to include the new Qwen-Image-Edit Plus model variant. The change is straightforward, but I've suggested a minor formatting tweak to ensure consistency with the rest of the document.

|:----------:|:--------:|
| Qwen-Image | [`Qwen/Qwen-Image`](https://huggingface.co/Qwen/Qwen-Image) |
| Qwen-Image-Edit | [`Qwen/Qwen-Image-Edit`](https://huggingface.co/Qwen/Qwen-Image-Edit) |
| Qwen-Image-Edit Plus | [Qwen/Qwen-Image-Edit-2509](https://huggingface.co/Qwen/Qwen-Image-Edit-2509) |
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For consistency with the other model IDs in the table, please wrap the model ID Qwen/Qwen-Image-Edit-2509 in backticks to render it as code.

Suggested change
| Qwen-Image-Edit Plus | [Qwen/Qwen-Image-Edit-2509](https://huggingface.co/Qwen/Qwen-Image-Edit-2509) |
| Qwen-Image-Edit Plus | [`Qwen/Qwen-Image-Edit-2509`](https://huggingface.co/Qwen/Qwen-Image-Edit-2509) |

@Dong1017 Dong1017 changed the title [docs/diffusers] update for qwenimage-edit-plus fix(diffusers): update md and fix dtype mismatch of qwenimage Jan 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant