fix: handle both reasoning_content and reasoning attributes#410
Closed
majiayu000 wants to merge 2 commits intomindverse:developfrom
Closed
fix: handle both reasoning_content and reasoning attributes#410majiayu000 wants to merge 2 commits intomindverse:developfrom
majiayu000 wants to merge 2 commits intomindverse:developfrom
Conversation
Fix AttributeError when using DeepSeek R1 API which returns 'reasoning' attribute instead of 'reasoning_content'. Use getattr with fallback to support both attribute names for backward compatibility with different API versions. Fixes mindverse#370, mindverse#327 Signed-off-by: majiayu000 <1835304752@qq.com>
|
|
Author
|
Closing this PR due to extended inactivity. Happy to reopen if there's still interest — feel free to comment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
AttributeError: 'ChatCompletionMessage' object has no attribute 'reasoning_content'when using DeepSeek R1 API.Changes
getattr()with fallback to handle bothreasoning_contentandreasoningattribute namesselfqa_generator.py,preference_QA_generate.py,diversity_data_generator.pyRelated Issues
Fixes #370, #327
Signed-off-by: majiayu000 1835304752@qq.com