Detect Frameworks after smart mode ready - #2630
Open
ghostflyby wants to merge 4 commits into
Open
Conversation
Member
|
In concept I like this change, but it is a lot. There's several merges here, can you rebase your branch to get a clean set of commits in this PR? |
ghostflyby
force-pushed
the
detection-index
branch
from
August 5, 2026 05:38
1841b28 to
c78554b
Compare
ghostflyby
force-pushed
the
detection-index
branch
from
August 5, 2026 05:53
c78554b to
908db7a
Compare
Member
|
Much nicer, thanks. |
DenWav
requested changes
Aug 9, 2026
DenWav
left a comment
DenWav
left a comment
Member
There was a problem hiding this comment.
I'm concerned about handling of CancellationException, but I haven't looked deeply enough into this PR yet, will do so when I get the time.
|
|
||
| class AdventurePresentationProvider : LibraryPresentationProvider<DummyLibraryProperties>(ADVENTURE_LIBRARY_KIND) { | ||
| override fun getIcon(properties: DummyLibraryProperties?) = PlatformAssets.ADVENTURE_ICON | ||
| class AdventureLibraryDetector : MinecraftLibraryDetector { |
Member
There was a problem hiding this comment.
All of these classes were renamed to *LibraryDetector, but the file name is still *PresentationProvider. The file name should match in this case.
| import com.intellij.psi.JavaPsiFacade | ||
| import com.intellij.psi.search.FilenameIndex | ||
| import com.intellij.psi.search.GlobalSearchScope | ||
| import java.util.* |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A performance improvement.
Use cases of
LibraryPresentationProviderby the IDE itself only matches the jar name by regex, proving that they are not intended for file iterations.Framework kind are useless when the index is not ready.
All tests passed.
closes #2475