Give mods access to imgui context#109
Open
GameParrot wants to merge 5 commits intominecraft-linux:masterfrom
Open
Give mods access to imgui context#109GameParrot wants to merge 5 commits intominecraft-linux:masterfrom
GameParrot wants to merge 5 commits intominecraft-linux:masterfrom
Conversation
ChristopherHX
requested changes
Dec 28, 2024
Member
ChristopherHX
left a comment
There was a problem hiding this comment.
Although this might read as a nice idea...
This is very very very very dangerous see git blame https://github.com/ocornut/imgui/blame/6982ce43f5b143c5dce5fab0ce07dd4867b705ae/imgui_internal.h#L2031-L2395C2
this struct is part of imgui internals and changes over time.
The whole struct layout get new items in the middle that moves other members in memory.
Doing this would stop updates of imgui in this launcher and for mods (this involves to remove the submodule updates for imgui), otherwise an unmaintainable change
Every mod must use a binary compatible snapshot of imgui, once the launcher bumps it mods are going to crash the process.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows mods to use imgui directly with ImGui::SetCurrentContext