Open
Conversation
get latest code
…etal-support * 'metal-support' of github.com:Mee-gu/new-renderer: use MTLPixelFormatDepth32Float_Stencil8 instead since it has better compatibility use MTLPixelFormatDepth32Float_Stencil8 instead since it has better compatibility 【Feature】add test case (minggo#109)
… code looks clean
Feature/to cache pipeline (minggo#110)
minggo
reviewed
Nov 9, 2018
minggo
reviewed
Nov 9, 2018
minggo
reviewed
Nov 9, 2018
minggo
reviewed
Nov 9, 2018
minggo
reviewed
Nov 9, 2018
minggo
reviewed
Nov 9, 2018
minggo
reviewed
Nov 9, 2018
minggo
reviewed
Nov 9, 2018
minggo
reviewed
Nov 9, 2018
| } | ||
|
|
||
| size_t DeviceMTL::findRenderPipelineInCache(const RenderPipelineDescriptor& descriptor) | ||
| { |
Owner
There was a problem hiding this comment.
Why not just return RenderPipeline*?
minggo
reviewed
Nov 9, 2018
added 3 commits
November 12, 2018 21:23
…0/std::numeric_limits<size_t>::max().
Mee-gu
commented
Nov 12, 2018
| } | ||
|
|
||
| return HashAlgorithm::PJWHash(info.c_str(), info.length()); | ||
| return std::hash<std::string>{}(info); |
Contributor
Author
There was a problem hiding this comment.
Use std::hash since the collision probability approaching 1.0/std::numeric_limits<size_t>::max().
minggo
reviewed
Nov 13, 2018
src/backend/Device.h
Outdated
| virtual RenderPipeline* newRenderPipeline(const RenderPipelineDescriptor& descriptor) = 0; | ||
|
|
||
| // Cache RenderPipeline for reuse | ||
| // virtual RenderPipeline* cacheRenderPipeline(const RenderPipelineDescriptor& descriptor) = 0; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cache ShaderModule, RenderPass and RenderPipeline for reuse