Ci/real linting#316
Draft
sneakers-the-rat wants to merge 5 commits into
Draft
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: #311
as #311 says - we didn't actually have linting/formatting enabled, just pyupgrade, so this is working us towards that.
there are a lot of things to fix in rules that i think we definitely need to have enabled, most notably for annotations which can only be kinda sorta inferred automatically, and oh boy the code here has some twists and turns with all these local closures and callbacks and whatnot.
it's good for us to be forced to take our medicine though! function annotations make the code much easier to work with, and who knows we might eventually get to a point where we can use mypy and numpydantic's type annotations to make the array passing a little less mysterious.
opening as a draft after just working through the
visualizationmodule, will come back to this another day, likely after we merge down the existing PRs.current outstanding fixes to do are like this: