Open
Conversation
6f6b86c to
d984398
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tokio-console is a standalone tool that can connect to the app and show currently running tokio tasks, which can be useful for debugging.
To integrate its support in the app:
console_subscribercrate and the result added as a tracing layer.To make the output of tokio-console understandable though, important tasks should have names, which can only be specified via unstable API. So I encapsulated tokio's task spawning functions in the corresponding functions in
utils. (I also moved the existing functions fromlogging/src/tracing_utils.rstoutilsand renamed them for consistency).To enable tokio-console support, build the app with
--features tokio-console.Here is how node-daemon tasks look like in tokio-console:

P.S. sometimes you'll also see tasks like these:

They come from
block_in_placecalls that mempool uses to access chainstate and are the result of the call tospawn_blockinghere, whichblock_in_placedoes to offload tasks from the current thread to another one.They don't correspond to any particular task in the app and can be ignored.