Update release actions to use master to trigger#2
Conversation
WalkthroughThe pull request updates .github/workflows/release_actions.yml by changing the branch trigger for the “Publish Docker image” workflow from main to master. No other workflow steps, jobs, or configuration elements are modified. There are no alterations to exported or public interfaces. Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
.github/workflows/release_actions.yml (2)
3-6: Verify default branch; consider supporting both master and main (plus manual trigger).If the repo’s default branch is still
main, this workflow will never run. To be safe during/after branch renames, include both branches and add a manualworkflow_dispatchtrigger.on: push: branches: - - master + - master + - main + workflow_dispatch:
18-18: Pin third‑party Actions to commit SHAs.For release workflows that publish artefacts, pin
actions/checkout,docker/login-action, anddocker/build-push-actionto specific commit SHAs to reduce supply‑chain risk. Keep a comment with the corresponding tag for readability.Also applies to: 25-25, 32-32, 47-47
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/release_actions.yml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (20)
- GitHub Check: qemu_riscv64
- GitHub Check: standard_v2
- GitHub Check: sanitize_undefined
- GitHub Check: settrace_stackless
- GitHub Check: macos
- GitHub Check: gil_enabled
- GitHub Check: stackless_clang
- GitHub Check: qemu_mips
- GitHub Check: nanbox
- GitHub Check: coverage_32bit
- GitHub Check: longlong
- GitHub Check: build_stm32 (stm32_misc_build)
- GitHub Check: build_stm32 (stm32_nucleo_build)
- GitHub Check: build_stm32 (stm32_pyb_build)
- GitHub Check: build_idf (esp32_build_c2_c6)
- GitHub Check: build_idf (esp32_build_s3_c3)
- GitHub Check: build
- GitHub Check: build_idf (esp32_build_cmod_spiram_s2)
- GitHub Check: build
- GitHub Check: build
|
Code size report: |
No description provided.