Skip to content

[pull] master from apache:master#574

Merged
pull[bot] merged 3 commits intomiqdigital:masterfrom
apache:master
Apr 5, 2026
Merged

[pull] master from apache:master#574
pull[bot] merged 3 commits intomiqdigital:masterfrom
apache:master

Conversation

@pull
Copy link
Copy Markdown

@pull pull bot commented Apr 5, 2026

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.4)

Can you help keep this open source service alive? 💖 Please sponsor : )

tbonelee and others added 3 commits April 5, 2026 14:57
…lar UI

### What is this PR for?
Fixes an issue where WebSocket reconnection in the new Angular UI (zeppelin-web-angular) does not reload the current note, causing "Note is null" errors when attempting to run paragraphs after reconnection.

### What type of PR is it?
Bug Fix

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-6387

### How should this be tested?

1. Open any notebook in the new Angular UI.
2. Trigger a WebSocket timeout by switching to another browser tab or window and leaving the Zeppelin tab in the background for a few minutes.
   - Even without interacting with the browser, you can confirm that the WebSocket has reconnected by checking the server logs.
3. Allow the system to automatically reconnect.
4. Try running any paragraph → It should fail before this PR and succeed after applying this PR.

### Questions:
* Does the license files need to update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No


Closes #5129 from tbonelee/websocket-reconnection.

Signed-off-by: ChanHo Lee <chanholee@apache.org>
### What is this PR for?

#### Summary

- Fixed dropdown menu items in header where only text was clickable instead of the full item area
- Changed routerLinkActive to nzMatchRouter for proper NG-ZORRO integration
- Added CSS pseudo-element to expand clickable area of anchor tags

#### Cause

- Likely due to NG-ZORRO dropdown menu item anchor tag style changes that reduced the clickable area to just the text content.

#### Changes

- Updated `header.component.html`: Replace `routerLinkActive` with `nzMatchRouter` directive
- Updated `global.less`: Add `::before` pseudo-element to `.ant-dropdown-menu-item > a` to expand clickable area using absolute positioning

### What type of PR is it?
Bug Fix

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-6384

### Questions:
* Does the license files need to update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No


Closes #5124 from tbonelee/fix-dropdown-link.

Signed-off-by: ChanHo Lee <chanholee@apache.org>
Bumps [requests](https://github.com/psf/requests) from 2.32.5 to 2.33.0.
- [Release notes](https://github.com/psf/requests/releases)
- [Changelog](https://github.com/psf/requests/blob/main/HISTORY.md)
- [Commits](psf/requests@v2.32.5...v2.33.0)

---
updated-dependencies:
- dependency-name: requests
  dependency-version: 2.33.0
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@pull pull bot added the ⤵️ pull label Apr 5, 2026
@pull pull bot merged commit 6f6df4c into miqdigital:master Apr 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant